Core-20: clear selection when user tab-navigates #2578
Conversation
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
c960db6 to
eb2267e
Compare
Dantemss
left a comment
Dantemss
left a comment
There was a problem hiding this comment.
Is this really what is needed to implement what is in the card? The card is just confusing to me and talks about a bunch of different things.
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
7c665b9 to
95a8381
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
2 times, most recently
from
9ec69a8 to
1b5aca0
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
1b5aca0 to
28a174b
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
6aa8611 to
af88dfe
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
af88dfe to
51c2df7
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
51c2df7 to
ca1d517
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
ca1d517 to
8af5ad9
Compare
Update EditCard.spec.tsx.snap
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
e45681f to
60e3ace
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
60e3ace to
e3de7c4
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
e3de7c4 to
df6cbaa
Compare
Dantemss
left a comment
Dantemss
left a comment
There was a problem hiding this comment.
@RoyEJohnson in prod when I select text I get the highlights popup
In this heroku deployment when I select text I get the new popup telling me to press enter or click to edit the highlight.
Is this intended?
|
@Dantemss Yes, that is intended. Several behaviors are changed here in hopes of making it more accessible-friendly (as well as mouse-friendly). Level Access had an issue with the dialog popping up and focus not auto-jumping to it (and when focus goes to it, the highlight is created, which we don't always want to do). |
| "i18n:highlighter:highlight:end:search": "End of search result", | ||
| "i18n:highlighter:highlight:start:search": "Start search result", | ||
| "i18n:highlighter:highlight:start-selected:search": "Start selected search result", | ||
| "i18n:highlighting:instructions": "Press Enter or click here to edit highlight", |
There was a problem hiding this comment.
I'd suggest changing this to create or edit but I realize getting the new translations is annoying
There was a problem hiding this comment.
I should really make two messages, depending on whether it's already a highlight.
Also need to get the translations reviewed. Do you remember who knows Polish?
There was a problem hiding this comment.
Well, it was someone in Katalyst. Maybe you can ask in katalyst-publishing on slack.
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
2563edd to
049555b
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
049555b to
57dcfb7
Compare
RoyEJohnson
deleted the
core-20-fix-clear-highlight-when-user-moves-focus
branch
CORE-20
CORE-1307
CORE-1314
CORE-1317
CORE-1318
CORE-1319